Update the to-do list for comments, and explain why we can't have a form for the whole comment

master
http://smcv.pseudorandom.co.uk/ 2009-02-03 13:33:59 -05:00 committed by Joey Hess
parent 9690356080
commit bc3fb1ceab
1 changed files with 17 additions and 11 deletions

View File

@ -10,19 +10,13 @@
> it's hard enough to get some people to title their blog posts :-) > it's hard enough to get some people to title their blog posts :-)
> --[[smcv]] > --[[smcv]]
## Patches pending merge
* There is some common code cargo-culted from other plugins (notably inline and editpage) which
should probably be shared
> Actually, there's less of this now than there used to be - a lot of simple
> things that were shared have become unshareable as they became more
> complex. --[[smcv]]
> There's still goto. You have a branch for that. --[[Joey]]
## Won't fix ## Won't fix
* Because IkiWiki generates static HTML, we can't have a form inlined in
page.tmpl where the user fills in an entire comment and can submit it in
a single button-press, without being vulnerable to cross-site request forgery.
So I'll put this in as wontfix. --[[smcv]]
* It would be useful to have a pagespec that always matches all comments on * It would be useful to have a pagespec that always matches all comments on
pages matching a glob. Something like `comment(blog/*)`. pages matching a glob. Something like `comment(blog/*)`.
Perhaps postcomment could also be folded into this? Then the pagespec Perhaps postcomment could also be folded into this? Then the pagespec
@ -47,6 +41,17 @@
## Done ## Done
* There is some common code cargo-culted from other plugins (notably inline and editpage) which
should probably be shared
> Actually, there's less of this now than there used to be - a lot of simple
> things that were shared have become unshareable as they became more
> complex. --[[smcv]]
> There's still goto. You have a branch for that. --[[Joey]]
>> Now merged --[[smcv]]
* The default template should have a (?) icon next to unauthenticated users (with the IP address * The default template should have a (?) icon next to unauthenticated users (with the IP address
as title) and an OpenID icon next to OpenIDs as title) and an OpenID icon next to OpenIDs
@ -91,6 +96,7 @@
> and c42f174e fix another `beautify_urlpath` bug and add a regression test > and c42f174e fix another `beautify_urlpath` bug and add a regression test
> --[[smcv]] > --[[smcv]]
* Now that inline has some comments-specific functionality anyway, it would * Now that inline has some comments-specific functionality anyway, it would
be good to output `<link rel="comments">` in Atom and the equivalent in RSS. be good to output `<link rel="comments">` in Atom and the equivalent in RSS.