urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

web commit by tuomov: Counter-review

master
joey 2007-02-20 16:35:58 +00:00
parent f36f4e4bbe
commit b74c51b8ec
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/patchqueue/index.html_allowed.mdwn
View File

@ -407,6 +407,16 @@ Index: linkmap.pm
}
</pre>
> This is probably supposed to be `$mapitems{$item}=urlto($item, $params{destpage});`,
> which does indeed remove one more `htmlpage` call from the plugins. I can't actually
> try it: "failed writing to dst/ts.png.ikiwiki-new: Inappropriate ioctl for device".
> After this probable fix, in fact, all uses of htmlpage in the plugins are used to
> construct an absolute address: the absolute url in most cases, so an `absurl`
> call could be added to be used instead of htmlpage, and something else in the
> aggregate plugin (above), that I also think isn't what's wanted:
> aren't `foo.html` pages also "rendered", so that they get moved as `foo/index.html`?
> --[[tuomov]]
* `inline.pm` uses htmlpage and `abs2rel` to generate a link, and probably
needs to be changed to either use `urlto` or to call `beautify_url` like
htmllink does. This might work: