urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

oh dear not fixed after all

master
http://kerravonsen.dreamwidth.org/ 2010-03-26 01:40:32 +00:00 committed by Joey Hess
parent 959d5b197d
commit b68aa11732
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/bugs/filecheck_failing_to_find_files.mdwn
View File

@ -13,7 +13,13 @@ It turns out that the filecheck plugin couldn't find the file, because it was me
>>> Ok, so it's not removal specific, can in fact be triggered by using
>>> testpagespec (or really anything besides attachment, which passes
>>> the filename parameter). Nor is it limited to mimetype, all the tests in
>>> filecheck have the problem. [[Fixed|done]] --[[Joey]]
>>> filecheck have the problem. --[[Joey]]
>>>> Alas, not fixed. It seems I was mistaken in some of my assumptions.
>>>> It still happens when attempting to remove attachments.
>>>> With your fix, the `IkiWiki::srcfile` function is only called when the filename is not passed in, but it appears that in the case of removing attachments, the filename IS passed in, but it is the relative filename as mentioned above. Thus, the file is still not found, and the mime-type comes back as unknown.
>>>> The reason my patch worked is because, rather than checking whether a filename was passed in before applying IkiWiki::srcfile to the filename, it checks whether the file can be found, and if it cannot be found, then it applies IkiWiki::srcfile to the filename.
>>>> --[[KathrynAndersen]]
The following patch fixes the problem: