goto permalink issue

master
Joey Hess 2011-01-05 15:34:35 -04:00
parent 3eabf323f0
commit b216f42e8e
1 changed files with 16 additions and 8 deletions

View File

@ -5,15 +5,23 @@
* CGI pages, with the exception of edit pages, set `<base>` to
`$config{url}`
I had to revert using `baseurl(undef)` for that, because it needs
to be a full url.
I had to revert using `baseurl(undef)` for that, because it needs
to be a full url.
Ideally, baseurl would return an absolute url derived from the url
being used to access the cgi, but that needs access to the CGI object,
which it does not currently have. Similarly, `misctemplate`
does not have access to the CGI object, so it cannot use it to
generate a better baseurl. Not sure yet what to do; may have to thread
a cgi parameter through all the calls to misctemplate. --[[Joey]]
Ideally, baseurl would return an absolute url derived from the url
being used to access the cgi, but that needs access to the CGI object,
which it does not currently have. Similarly, `misctemplate`
does not have access to the CGI object, so it cannot use it to
generate a better baseurl. Not sure yet what to do; may have to thread
a cgi parameter through all the calls to misctemplate. --[[Joey]]
* Using `do=goto` to go to a comment or recentchanges item
will redirect to the `$config{url}`-based url, since the
permalinks are made to be absolute urls now.
Fixing this would seem to involve making meta force permalinks
to absolute urls when fulling out templates, while allowing them
to be left as partial urls internally, for use by goto. --[[Joey]]
## old attempt