urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

respond to smcv's comment

master
chrysn 2014-07-03 04:36:51 +02:00
parent ee72b1e032
commit a6f4dcd495
1 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
doc/bugs/pythonproxy-utf8_again.mdwn
View File

@ -18,17 +18,17 @@ patch.
> update 2014-06-29: the problem persists, but i found it is not trivial to > update 2014-06-29: the problem persists, but i found it is not trivial to
> reproduce. to demonstrate, use this test plugin: > reproduce. to demonstrate, use this test plugin:
> >
> #!/usr/bin/env python > #!/usr/bin/env python
> # -*- coding: utf-8 -*- > # -*- coding: utf-8 -*-
> >
> from proxy import IkiWikiProcedureProxy > from proxy import IkiWikiProcedureProxy
> >
> def preprocess(self, proxy, *args): > def preprocess(self, proxy, *args):
> return repr(self.rpc('pagetype', 'schön')) > return repr(self.rpc('pagetype', 'schön'))
> >
> proxy = IkiWikiProcedureProxy(__name__) > proxy = IkiWikiProcedureProxy(__name__)
> proxy.hook('preprocess', preprocess, id='testdirective') > proxy.hook('preprocess', preprocess, id='testdirective')
> proxy.run() > proxy.run()
> >
> note that when the 'schön' is stored in a variable, the exception changes -- > note that when the 'schön' is stored in a variable, the exception changes --
> it seems to me that the issue is related to the way exceptions are encoded. > it seems to me that the issue is related to the way exceptions are encoded.
@ -46,3 +46,9 @@ patch.
>> >>
>> Other than that it looks good to me. I like the use of `repr` in debug >> Other than that it looks good to me. I like the use of `repr` in debug
>> messages. --[[smcv]] >> messages. --[[smcv]]
>>> afaict, encode is fine there -- the relevant methods in python2 are
>>> `unicode.encode` which gives a `str`, and `str.decode` which usually gives
>>> a `unicode`. (i'd happily ditch python2 and port all plugins to python3,
>>> where this is all easier, but my [[todo/vCard rendering]] still uses an
>>> ancient module.) --[[chrysn]]