Avoid trying to log the user in when receiving anonymous pushes from git and a plugin like httpauth returns a login function.

Just use check_canedit in nonfatal mode.

IkiWiki/Receive.pm

@@ -95,8 +95,7 @@ sub test () {
 		if ($change->{action} eq 'change' ||
 		    $change->{action} eq 'add') {
 			if (defined $page) {
-				IkiWiki::check_canedit($page, $cgi, $session);
-				next;
+				next if IkiWiki::check_canedit($page, $cgi, $session, 1);
 			}
 			else {
 				if (IkiWiki::Plugin::attachment->can("check_canattach")) {

debian/changelog

@@ -23,6 +23,8 @@ ikiwiki (3.20100816) UNRELEASED; urgency=low
     setup. (intrigeri)
   * t/bazaar.t: Work around bzr 2.2.0's new requirement to configure
     bzr whoami before committing.
+  * Avoid trying to log the user in when receiving anonymous pushes
+    from git and a plugin like httpauth returns a login function.
 
  -- Joey Hess <joeyh@debian.org>  Sun, 15 Aug 2010 11:45:48 -0400
 

doc/bugs/httpauth_conflicts_with_git_anon_push.mdwn

@@ -22,4 +22,4 @@ Analysis:
 
 So, all these calls need to avoid running the error handler
 functions returned by canedit hooks, and just return error
-messages.
+messages. [[done]] --[[Joey]]