From 9e7dcefd7ed9424de20706f63c7bab5182c5df78 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 2 Apr 2010 17:26:32 -0400 Subject: [PATCH] comments --- .../allow_plugins_to_add_sorting_methods.mdwn | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/doc/todo/allow_plugins_to_add_sorting_methods.mdwn b/doc/todo/allow_plugins_to_add_sorting_methods.mdwn index e4e1829dc..67d85f6f8 100644 --- a/doc/todo/allow_plugins_to_add_sorting_methods.mdwn +++ b/doc/todo/allow_plugins_to_add_sorting_methods.mdwn @@ -50,6 +50,21 @@ NIH'd sorting mechanisms: >>> share the `IkiWiki::PageSpec` package, but with a `cmp_` prefix. Gitweb: >>> +>>>> I agree it seems more elegant, so I have focused on it. +>>>> +>>>> I don't know about reusing `IkiWiki::PageSpec` for this. +>>>> +>>>> I would be inclined to drop the `check_` stuff. +>>>> +>>>> Wouldn't it make sense to have `meta(title)` instead +>>>> of `meta_title`? +>>>> +>>>> As I read the regexp in `cmpspec_translate`, the "command" +>>>> is required to have params. They should be optional, +>>>> to match the documentation and because most sort methods +>>>> do not need parameters. +>>>> --[[Joey]] + ## Documentation from sort-hooks branch ### sort hook (added to [[plugins/write]])