urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

master
Joey Hess 2010-06-14 14:11:35 -04:00
parent 88b080f8a4 8746480c25
commit 98ad266119
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
doc/bugs/misctemplate_does_not_respect_the_current_page___40__if_any__41__.mdwn
View File

@ -24,6 +24,15 @@ But it causes some nasty bugs for plugins that use the pagetemplate hook. It is
> The [[version_3.20100515]] announcment mentions that you need to > The [[version_3.20100515]] announcment mentions that you need to
> update old `page.tmpl` files to include that on upgrade. --[[Joey]] > update old `page.tmpl` files to include that on upgrade. --[[Joey]]
>> I followed the anouncment. I also disabled my custom page.tmpl to confirm the bug. I even produced a step-by-step example to reproduce the bug.
>> In fact, the base tag work for the page links (the content part) but did not works for the sidebar links (the sidebar part) since the sidebar links are generated in the context of the root page.
>> In the examble above:
>>
>> * base="http://www.example.com/bar" relative_link_in_bar=''something" -> absolute_link_in_bar = "http://www.example.com/bar/something" (that is fine)
>> * base="http://www.example.com/bar" relative_link_in_sidebar="foo" (because generated in the context of the root page) -> absolute_link_in_sidebar = "http://www.example.com/bar/foo" (that is not fine)
>>
>> The fix commited work for previewing, but not in other cases : links are still broken. Please juste follow the example step-by-step to reproduce it (I just retried it with a "fixed" version: Debian 3.20100610). If you cannot reproduce, please say it explicitely instead of guessing about my innability to read changelogs. -- [[JeanPrivat]]
### A second example ### A second example
* create "/bar/sidebar.mdwn" with "world" * create "/bar/sidebar.mdwn" with "world"
@ -39,6 +48,13 @@ But it causes some nasty bugs for plugins that use the pagetemplate hook. It is
> the "are you sure" confirmation page to display the page's sidebar? > the "are you sure" confirmation page to display the page's sidebar?
> --[[Joey]] > --[[Joey]]
>> It is a very good point and could be argued:
>>
>> * for dynamic page, is the root context more legitimate than the current page context?
>> * when clicking the Edit link, does the user expect to remain in the "same page"?
>>
>> But, as far as something sensible is displayed and that the links work. I'm OK with any choice. -- [[JeanPrivat]]
### A last example ### A last example
* with the web browser edit the page "bar" * with the web browser edit the page "bar"
@ -54,6 +70,13 @@ But it causes some nasty bugs for plugins that use the pagetemplate hook. It is
> put the sidebar anywhere so we can't just display the preview sidebar > put the sidebar anywhere so we can't just display the preview sidebar
> next to the rest of the page preview. --[[Joey]] > next to the rest of the page preview. --[[Joey]]
>> The behavior is fine for me. However, some nitpicking (fell free to ingore) :
>>
>> * If the sidebar is replaced (making the previewing in-place), for consitency, should not the previewed content also shown in-place ? i.e. above the form part
>> * there is no way to come back (without saving or canceling) to the root context (e.g. displaying the root sidebar) i.e. some sort of unpreviewing.
>>
>> -- [[JeanPrivat]]
## Some superficial hacking ## Some superficial hacking
With the following workaround hacks, I manage to solve the 3 examples shown above: With the following workaround hacks, I manage to solve the 3 examples shown above:
@ -70,5 +93,5 @@ this bug but it may help developers to find and solve the real problem.
> Oh, it's pretty reasonable. I don't think it breaks anything. :) > Oh, it's pretty reasonable. I don't think it breaks anything. :)
> I modified it a bit, and explicitly made it *not* "fix" the second example. > I modified it a bit, and explicitly made it *not* "fix" the second example.
> [[done]]
> --[[Joey]] > --[[Joey]]
>> I removed the done tag (I suspect it is the way to reopen bugs) -- [[JeanPrivat]]