review
parent
313b06878c
commit
8cd0a1c434
|
@ -4,6 +4,9 @@ example when submitting a [[patch]], you can use the
|
|||
|
||||
\[[!template id=gitbranch branch=yourrepo/amazingbranch author="\[[yourname]]"]]
|
||||
|
||||
Branches that have been [[reviewed]] and need work will not be listed
|
||||
here.
|
||||
|
||||
Branches referred to in open [[bugs]] and [[todo]]:
|
||||
|
||||
[[!inline pages="(todo/* or bugs/*) and link(/branches) and !link(bugs/done)
|
||||
|
|
|
@ -0,0 +1,6 @@
|
|||
This page lists [[branches]] that have been reviewed. If your branch
|
||||
shows up here, the ball is back in your court, to respond to the review and
|
||||
deal with whatever is preventing it from being merged into ikiwiki.
|
||||
|
||||
[[!inline pages="(todo/* or bugs/*) and link(/branches) and !link(bugs/done)
|
||||
and !link(todo/done) and !*/*/* and link(.)" show=0 archive=yes]]
|
|
@ -64,3 +64,23 @@ usage
|
|||
>>> will be easier to merge or reject. Note the new branch name:
|
||||
>>> `raw_inline`. I'll open separate todo items for items mentioned in my
|
||||
>>> previous comment. --[[wtk]]
|
||||
|
||||
----
|
||||
|
||||
Reviewing your patch the first thing I see is this:
|
||||
|
||||
<pre>
|
||||
+ if (! $file) {
|
||||
+ error("Missing file.");
|
||||
+ }
|
||||
</pre>
|
||||
|
||||
This fails if the filename is "0". Also, `pagetype()`
|
||||
currently cannot fail; allowing it to crash the entire
|
||||
wiki build if the filename is somehow undefined seems
|
||||
unwise.
|
||||
|
||||
I didn't look much further, because it seems to me what you're trying to do
|
||||
can be better accomplished by using the highlight plugin. Assuming the raw
|
||||
file you want to inline and comment on is some source-code-like thing,
|
||||
which seems likely. --[[Joey]] [[!tag reviewed]]
|
||||
|
|
Loading…
Reference in New Issue