t/git-cgi.t: Wait 1 second before doing a revert that should succeed

This hopefully fixes a race condition in which the test failed
around 6% of the time.

If we don't wait, the mtime (which is rounded down to 1 second precision
in the APIs we use) will not necessarily change, so the update will not
necessarily cause the page to be refreshed.

Bug-Debian: https://bugs.debian.org/862494
master
Simon McVittie 2017-05-14 15:09:29 +01:00
parent 365a930c2c
commit 8b5c729b8b
2 changed files with 12 additions and 0 deletions

8
debian/changelog vendored
View File

@ -1,3 +1,11 @@
ikiwiki (3.20170112) UNRELEASED; urgency=medium
* t/git-cgi.t: Wait 1 second before doing a revert that should work.
This hopefully fixes a race condition in which the test failed
around 6% of the time. (Closes: 862494)
-- Simon McVittie <smcv@debian.org> Sun, 14 May 2017 15:34:52 +0100
ikiwiki (3.20170111) unstable; urgency=high
* passwordauth: prevent authentication bypass via multiple name

View File

@ -291,6 +291,10 @@ sub test {
$content = readfile('t/tmp/in/two.mdwn');
like($content, qr{Here is new content for the second page});
# We have to wait 1 second here so that new writes are guaranteed
# to have a strictly larger mtime.
sleep 1;
# This one can legitimately be reverted
$content = run_cgi(method => 'post',
params => {