urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update on plugin progress

master
Tincho 2018-08-18 14:44:19 -04:00 committed by admin
parent b7c2571d90
commit 8b44fde854
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/plugins/osm/discussion.mdwn
View File

@ -45,9 +45,11 @@ For usability it would be great if it was possible to display the active waypoin
- Maps actually work again - Maps actually work again
- Maps work when embedded in HTTPS sites - Maps work when embedded in HTTPS sites
- Multiple maps and multiple waypoints in a page probably work better now - Multiple maps and multiple waypoints in a page work properly
- Maps _do_ appear in inlines - Maps _do_ appear in inlines
- Pagestate hash gets cleaned up better after edit/preview/delete - Pagestate hash gets cleaned up better after edit/preview/delete
- Unigue icon for "active waypoint" works, also possible to select manually any waypoint to highlight
- Good test coverage, including inlines and multiple maps/waypoints per page
### Wishlist ### Wishlist
@ -62,7 +64,7 @@ For usability it would be great if it was possible to display the active waypoin
- Given this is backward-incompatible, dhould we call it something other than "osm"? - Given this is backward-incompatible, dhould we call it something other than "osm"?
- What needs scrubbing? Have we covered all the bases? Too many bases? - What needs scrubbing? Have we covered all the bases? Too many bases?
- Should we vendor Leaflet into an underlay, instead of needing a URL to load it from a CDN? [[schmonz]] somewhat prefers this, so we avoid needing external resources by default, avoid breaking when the Leaflet CDN is down, etc. - Should we vendor Leaflet into an underlay, instead of needing a URL to load it from a CDN? [[schmonz]] somewhat prefers this, so we avoid needing external resources by default, avoid breaking when the Leaflet CDN is down, etc.
- Should we write some tests before merging? `osm.pm` hadn't had any, FWIW - Should we write some tests before merging? `osm.pm` hadn't had any, FWIW -- [[Tincho]] Done
Bump! Tincho would like to see us merge his effort, and FWIW I'd also Bump! Tincho would like to see us merge his effort, and FWIW I'd also
rather not have to carry around a local copy of his work to get a map rather not have to carry around a local copy of his work to get a map
@ -80,3 +82,5 @@ Looks like good changes to me!
> did a grep `Placemark pois.kml|wc -l` which returned 3468. Which perhaps isn't that much? I'm thinking about how individual poi files might affect performance. My performance troubles are more likely to be with my tweaked album and img plugins though. > did a grep `Placemark pois.kml|wc -l` which returned 3468. Which perhaps isn't that much? I'm thinking about how individual poi files might affect performance. My performance troubles are more likely to be with my tweaked album and img plugins though.
--[[kjs]] --[[kjs]]
> The issue about not getting all the waipoints until you rebuild has been solved, the current plugin had issues with keeping track of updated and deleted waypoints which is now fixed in my branch. --[[Tincho]]