From 83afe165366fd6cffd42ea47d6604d90a07143a3 Mon Sep 17 00:00:00 2001 From: Christopher Baines Date: Sun, 6 Jul 2014 22:05:45 +0100 Subject: [PATCH] Respond to smcv on the album discussion page --- doc/plugins/contrib/album/discussion.mdwn | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/doc/plugins/contrib/album/discussion.mdwn b/doc/plugins/contrib/album/discussion.mdwn index 58c0e640f..d8f55eb33 100644 --- a/doc/plugins/contrib/album/discussion.mdwn +++ b/doc/plugins/contrib/album/discussion.mdwn @@ -614,6 +614,14 @@ concatenates them: for instance, `/usr/share/ikiwiki/themes/actiontabs/style.css is the output of `cat doc/style.css themes/actiontabs/style.css`. So adding it to `doc/style.css` should be enough? +> I don't think this is the case? Or at least, looking at the generated +> stylesheet for the examples built using my branch, I would expect there to be +> two copies of the album rules in the stylesheet [1], but there does not +> appear to be. This could quite easily be a result of some mistake in my part +> in not isolating the build though. --[[cbaines]] +> +> 1: + Regarding commit `Change the default thumbnail size`: as far as I understand it, `size => 96x96` is meant to set the image size to be as large as possible given these constraints: width ≤ 96px, @@ -623,3 +631,7 @@ are you seeing, and which versions of Imagemagick and Perlmagick are you using? --[[smcv]] + +> I rebuilt the examples using both your album4 and album5 branches, and I only +> see this in the album4 branch. So this is probably ok to ignore. +> --[[cbaines]]