urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

avoid hitting the shell with system()

master
Joey Hess 2008-11-05 14:45:45 -05:00
parent b76ee8a96d
commit 7e95723dad
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
IkiWiki/Plugin/po.pm
View File

@ -149,8 +149,7 @@ sub refreshpofiles ($@) { #{{{
foreach my $pofile (@pofiles) { foreach my $pofile (@pofiles) {
if (-e $pofile) { if (-e $pofile) {
my $cmd = "msgmerge -U --backup=none $pofile $potfile"; system("msgmerge", "-U", "--backup=none", $pofile, $potfile) == 0
system ($cmd) == 0
or error("[po/refreshpofiles:$pofile] failed to update"); or error("[po/refreshpofiles:$pofile] failed to update");
} }
else { else {

10
doc/plugins/po.mdwn
View File

@ -205,7 +205,7 @@ Translating
One can edit the PO files using ikiwiki's CGI (a message-by-message interface One can edit the PO files using ikiwiki's CGI (a message-by-message interface
could also be implemented at some point). could also be implemented at some point).
If [[tips/untrusted_git_push]] is setup, one can edit the PO files in her If [[tips/untrusted_git_push]] is setup, one can edit the PO files in one's
preferred `$EDITOR`, without needing to be online. preferred `$EDITOR`, without needing to be online.
TODO TODO
@ -267,6 +267,14 @@ by something like [[todo/using_meta_titles_for_parentlinks]].
Which configuration settings are safe enough for websetup? Which configuration settings are safe enough for websetup?
> I see no problems with `po_master_language` and `po_slave_languages`
> (assuming websetup handles the hashes correctly). Would not hurt to check
> that the values of these are legal language codes, in `checkconfig`.
> `po_translatable_pages` seems entirely safe. `po_link_to` w/o usedirs
> causes ikiwiki to error out. If it were changed to fall back to a safe
> setting in this case rather than error, it would be safe.
> --[[Joey]]
### parentlinks ### parentlinks
When the wiki home page is translatable, the parentlinks plugin sets When the wiki home page is translatable, the parentlinks plugin sets