urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

master
https://www.google.com/accounts/o8/id?id=AItOawmUWmB1M35_jviFvGPYDIH-a-_Al-7OrXM 2011-07-19 12:18:51 -04:00 committed by admin
parent 8786fbfbbc
commit 758a4c23fd
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
View File

@ -9,10 +9,14 @@ Diff follows. --[[Daniel Andersson]]
> itself and it would just be clutter to mention what file was changed, > itself and it would just be clutter to mention what file was changed,
> since any reasonable interface will show the filename, or a link, > since any reasonable interface will show the filename, or a link,
> or some summary of what files were affected when showing a change. > or some summary of what files were affected when showing a change.
>
>> I use the Mercurial backend, and Mercurial doesn't allow empty commit messages, so if there were no message, it would default to "no message given" (hardcoded in `mercurial.pm`), which is also clutter, and non-descriptive at that. But I'm on board with your reasoning. It's a matter of taste (and somewhat backend), I guess. I might continue to locally use this patch (with the caveat below fixed when commit message is given), but I won't push for it to be included upstream. --[[Daniel Andersson]]
> Also your patch stomps over any commit message that the user *does* > Also your patch stomps over any commit message that the user *does*
> provide, so certianly cannot be applied as-is. --[[Joey]] > provide, so certianly cannot be applied as-is. --[[Joey]]
>> Yes, "naive" was the word :-) . --[[Daniel Andersson]]
[[!tag patch]] [[!tag patch]]
--- ---