urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Report authorization bypass via RCS revert.

master
intrigeri 2016-12-17 11:11:44 +00:00
parent bd46db3fb9
commit 706bf876ea
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
doc/bugs/rcs_revert_can_bypass_authorization_if_affected_files_were_renamed.mdwn 100644
View File

@ -0,0 +1,14 @@
1. We have a `$srcdir/writable/page.mdwn` source file in Git.
2. ikiwiki is configured to allow edits via the CGI in `writable/*`,
but nowhere else.
2. Modify `$srcdir/writable/page.mdwn`, commit ⇒ commit `$id`.
3. `git mv $srcdir/writable/page.mdwn $srcdir/read-only/page.mdwn`
⇒ The web interface allows reverting commit `$id` (presumably because
it changes files only in `$srcdir/writable`). This operation
effectively modifies `$srcdir/read-only/page.mdwn`, which feels wrong.
My guess is that `check_canchange` does not take into account that Git
will automatically detect that the file affected by the to-be-reverted
commit has moved, and modify the file in its new location
when reverting.