urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove patch tag, the patch here was merged

master
smcv 2014-07-03 17:49:02 -04:00 committed by admin
parent 03ee0fd9f7
commit 6d90e56c8d
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
doc/bugs/syslog_fails_with_non-ASCII_wikinames.mdwn
View File

@ -18,10 +18,15 @@ Yet I am not sure how to fix that kind of problem in Perl... --[[anarcat]]
> >
> Error: Wide character in syswrite at /usr/lib/perl/5.14/Sys/Syslog.pm line 485. > Error: Wide character in syswrite at /usr/lib/perl/5.14/Sys/Syslog.pm line 485.
> >
> I have improved a little the error handling in log_message() so that we see *something* when syslog fails, see the branch documented above. I can also confirm that reverting [[todo/syslog_should_show_wiki_name]] fixes the bug. Finally, I have a unit test that reproduces the problem in git, and a working [[!taglink patch]] for the bug, again in git. > I have improved a little the error handling in log_message() so that we see *something* when syslog fails, see the branch documented above. I can also confirm that reverting [[todo/syslog_should_show_wiki_name]] fixes the bug. Finally, I have a unit test that reproduces the problem in git, and a working patch for the bug, again in git.
> >
> > One last note: I noticed that this problem also happens elsewhere in ikiwiki. For example, the [[plugins/notifyemail]] plugin will silently fail to send notifications if the pages contain unicode. The [[plugins/notifychanges]] plugin I am working on (in [[todo/option to send only the diff in notifyemail]]) seems to be working around the issue so far, but there's no telling which similar problem are out there. > > One last note: I noticed that this problem also happens elsewhere in ikiwiki. For example, the [[plugins/notifyemail]] plugin will silently fail to send notifications if the pages contain unicode. The [[plugins/notifychanges]] plugin I am working on (in [[todo/option to send only the diff in notifyemail]]) seems to be working around the issue so far, but there's no telling which similar problem are out there.
>> [[I'd merge it|/users/smcv/yesplease]]. --[[smcv]] >> I'd merge it. --[[smcv]]
>>> I've merged it, but I don't feel it fixes this bug. --[[Joey]] >>> I've merged it, but I don't feel it fixes this bug. --[[Joey]]
>>>> (I removed the patch tag to take it off the patches list.)
>>>>
>>>> What else is needed? Systematic classification of outputs into
>>>> those that do and don't cope with Unicode? --[[smcv]]