urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

textile-double-escape-bug.t: tolerate any valid encoding 

Discount in current Debian unstable turns the IURI href into a URI
by encoding the Unicode as UTF-8 and %-escaping each byte.
That is valid, and matches Wikipedia's expectations, but was breaking
this test for me.

It would also be entirely valid (and lead to equivalent parsing) if the
ö was represented as ö, ö or &#xf6 in the text and/or the href.
master
Simon McVittie 2015-01-06 00:26:41 +00:00
parent 4315581f31
commit 6b6d330bad
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
t/textile-double-escape-bug.t
View File

@ -14,20 +14,22 @@ BEGIN {
subtest 'Text::Textile apparently double-escapes HTML entities in hrefs' => sub { subtest 'Text::Textile apparently double-escapes HTML entities in hrefs' => sub {
my $text = q{Gödel, Escher, Bach}; my $text = q{Gödel, Escher, Bach};
my $text_ok = qr{G(?:ö|ö|ö|&#x[fF]6;)del, Escher, Bach};
my $href = q{https://en.wikipedia.org/wiki/Gödel,_Escher,_Bach}; my $href = q{https://en.wikipedia.org/wiki/Gödel,_Escher,_Bach};
my $good = qq{<p><a href="$href">$text</a></p>}; my $href_ok = qr{https://en\.wikipedia\.org/wiki/G(?:ö|&ouml;|&#246;|&#x[fF]6|%[cC]3%[bB]6)del,_Escher,_Bach};
my $good = qr{<p><a href="$href_ok">$text_ok</a></p>};
chomp(my $mdwn_html = IkiWiki::Plugin::mdwn::htmlize( chomp(my $mdwn_html = IkiWiki::Plugin::mdwn::htmlize(
content => qq{[$text]($href)}, content => qq{[$text]($href)},
)); ));
is($mdwn_html, $good); like($mdwn_html, $good);
chomp(my $txtl_html = IkiWiki::Plugin::textile::htmlize( chomp(my $txtl_html = IkiWiki::Plugin::textile::htmlize(
content => qq{"$text":$href}, content => qq{"$text":$href},
)); ));
TODO: { TODO: {
local $TODO = "Text::Textile double-escapes the href"; local $TODO = "Text::Textile double-escapes the href";
is($txtl_html, $good); like($txtl_html, $good);
isnt($txtl_html, q{<p><a href="https://en.wikipedia.org/wiki/G&amp;ouml;del,_Escher,_Bach">G&ouml;del, Escher, Bach</a></p>}); unlike($txtl_html, qr{<p><a href="https://en\.wikipedia\.org/wiki/G&amp;ouml;del,_Escher,_Bach">G&ouml;del, Escher, Bach</a></p>}i);
} }
}; };