From 68e23206961862a2b05f99ea0bbe82fe28e21367 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 21 Sep 2016 13:51:42 -0400 Subject: [PATCH] inline: Prevent creating a file named ".mdwn" when the postform is submitted with an empty title. --- IkiWiki/Plugin/inline.pm | 3 +++ debian/changelog | 7 +++++++ doc/bugs/inline_postform_empty_title.mdwn | 4 +++- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/IkiWiki/Plugin/inline.pm b/IkiWiki/Plugin/inline.pm index 19dd684dd..a85cd5d2f 100644 --- a/IkiWiki/Plugin/inline.pm +++ b/IkiWiki/Plugin/inline.pm @@ -121,6 +121,9 @@ sub sessioncgi ($$) { if ($q->param('do') eq 'blog') { my $page=titlepage(decode_utf8(scalar $q->param('title'))); $page=~s/(\/)/"__".ord($1)."__"/eg; # don't create subdirs + if (! length $page) { + error(gettext("please enter a page title")); + } # if the page already exists, munge it to be unique my $from=$q->param('from'); my $add=""; diff --git a/debian/changelog b/debian/changelog index 1fed2c096..ec15142b4 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +ikiwiki (3.20160906) UNRELEASED; urgency=medium + + * inline: Prevent creating a file named ".mdwn" when the + postform is submitted with an empty title. + + -- Joey Hess Wed, 21 Sep 2016 13:48:32 -0400 + ikiwiki (3.20160905) unstable; urgency=medium [ Joey Hess ] diff --git a/doc/bugs/inline_postform_empty_title.mdwn b/doc/bugs/inline_postform_empty_title.mdwn index 4de08af86..5fa610285 100644 --- a/doc/bugs/inline_postform_empty_title.mdwn +++ b/doc/bugs/inline_postform_empty_title.mdwn @@ -1,4 +1,6 @@ When using inline with postform=yes, the user can click on the edit button without providing a title, and are allowed to save the page. This results in a file with a name like ".mdwn", which ikiwiki won't render. --[[Joey]] +--[[Joey]] + +> [[done]]; made it error out in this case.