urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

po: back to the cansave hook, as the form validation is not sufficient 

Form validation works, but after trying to save invalid PO content, the user is
brought back to the page he/she was editing, without any single clue to explain
why it was not saved. The dedicated cansave hook is thus necessary.

Signed-off-by: intrigeri <intrigeri@boum.org>
master
intrigeri 2009-01-02 18:51:32 +01:00
parent 7ef0c19cdf
commit 4ad871810d
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
IkiWiki/Plugin/po.pm
View File

@ -39,7 +39,7 @@ sub import {
hook(type => "rename", id => "po", call => \&renamepages, first => 1); hook(type => "rename", id => "po", call => \&renamepages, first => 1);
hook(type => "delete", id => "po", call => \&mydelete); hook(type => "delete", id => "po", call => \&mydelete);
hook(type => "change", id => "po", call => \&change); hook(type => "change", id => "po", call => \&change);
# hook(type => "cansave", id => "po", call => \&cansave); hook(type => "cansave", id => "po", call => \&cansave);
hook(type => "canremove", id => "po", call => \&canremove); hook(type => "canremove", id => "po", call => \&canremove);
hook(type => "canrename", id => "po", call => \&canrename); hook(type => "canrename", id => "po", call => \&canrename);
hook(type => "editcontent", id => "po", call => \&editcontent); hook(type => "editcontent", id => "po", call => \&editcontent);
@ -503,15 +503,6 @@ sub formbuilder (@) {
} }
} }
} }
# Prevent invalid PO content to be saved.
# This cannot be done in the formbuilder_setup hook as the editpage plugin
# unconditionally sets the editcontent field's validate code later.
elsif ($form->field("do") eq "edit") {
if (istranslation($form->field("page"))) {
$form->field(name => "editcontent", validate => \&isvalidpo);
}
}
} }
# ,---- # ,----