don't use utf8::valid, maybe print $file

master
https://www.google.com/accounts/o8/id?id=AItOawlVTXTWaOzAMhKML3EH8LH99Mu_TrvHhEA 2014-01-11 18:36:47 -04:00 committed by admin
parent ed90210efa
commit 42aebb6eb8
1 changed files with 9 additions and 0 deletions

View File

@ -0,0 +1,9 @@
Hunting down what was generating
utf8 "\xEB" does not map to Unicode at /usr/share/perl5/IkiWiki.pm line 873, <$in> chunk 1.
lead me to a call to `utf8::valid`, which lead to http://perldoc.perl.org/utf8.html which says this is an "INTERNAL" function:
> Main reason for this routine is to allow Perl's testsuite to check that operations have left strings in a consistent state. You most probably want to use `utf8::is_utf8()` instead.
Apparently the main point of the function is to emit the warning in unit tests - problem is, in the ikiwiki context, the only useful thing to warn about would be the name of the file you're trying to parse, not the name of the source code. Alternatively, since the code does continue on with the data, *not* whining about it might be an option :-) but an actionable message would be better.