urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

review

master
Joey Hess 2009-09-11 14:44:32 -04:00
parent 06c712a7f0
commit 412a4dd62a
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
doc/plugins/contrib/rsync/discussion.mdwn
View File

@ -46,3 +46,17 @@ The wiki now lives on (1), and clicking "edit" just works. --[[schmonz]]
>> This plugin is definitely still useful for projects not able to use
>> a DVCS (of which I've got at least one other), and possibly for
>> other uses not yet imagined. ;-) --[[schmonz]]
----
Revew: --[[Joey]]
* I think it should not throw an error if no command is set. Just don't do anything.
* If the rsync fails, it currently errors out, which will probably also leave
the wiki in a broken state, since ikiwiki will not get a chance to save
its state. This seems fragile; what if the laptop is offline, or the
server is down, etc. Maybe it should just warn if the rsync fails?
* Is a new hook really needed? The savestate hook runs at a similar time;
only issue with it is that it is run even when ikiwiki has not
rendered any updated pages. Bah, I think you do need the new hook, how
annoying..