Populate pagectime from mtime or inode change time, whichever is older

When building ikiwiki from a tarball, the mtime (conceptually, the
last modification date of the file) is preserved by tar, but the inode
change time (creation/metadata-change date of *this copy* of the file)
is not. This seems to lead to unstable sort ordering and
unreproducible builds.

The page can't possibly have been modified before it was created, so
we can assume that the modification date is an upper bound for the
creation date.
master
Simon McVittie 2015-06-09 22:22:54 +01:00
parent b6388d6fbd
commit 2fe003dac4
2 changed files with 7 additions and 1 deletions

View File

@ -474,7 +474,11 @@ sub find_new_files ($) {
}
$pagecase{lc $page}=$page;
if (! exists $pagectime{$page}) {
my $ctime=(srcfile_stat($file, 1))[10];
my @stat=srcfile_stat($file, 1);
# For the creation time of the page, take the
# inode change time (not creation time!) or
# the modification time, whichever is older.
my $ctime=($stat[10] < $stat[9] ? $stat[10] : $stat[9]);
$pagectime{$page}=$ctime if defined $ctime;
}
}

2
debian/changelog vendored
View File

@ -21,6 +21,8 @@ ikiwiki (3.20150330) UNRELEASED; urgency=medium
* Make the attachment plugin work with CGI.pm 4.x (Closes: #786586;
workaround for #786587 in libcgi-pm-perl)
* Add a public-domain email icon from tango-icon-theme
* Populate pagectime from either mtime or inode change time,
whichever is older, again for more reproducible builds
-- Joey Hess <id@joeyh.name> Tue, 28 Apr 2015 12:24:08 -0400