urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

review

master
Joey Hess 2009-03-27 15:51:13 -04:00
parent c8237b4351
commit 2852cf14a2
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
doc/plugins/contrib/po.mdwn
View File

@ -328,3 +328,14 @@ but the po thing is supposed to work without these ugly `our`.
Seems like it was the last unaddressed item from Joey's review, so I'm Seems like it was the last unaddressed item from Joey's review, so I'm
daring a timid "please pull"... or rather, please review again :) daring a timid "please pull"... or rather, please review again :)
--[[intrigeri]] --[[intrigeri]]
> Ok, I've reviewed and merged into my own po branch. It's looking very
> mergeable. I would still like to go over the `po.pm` code in detail and
> review it, but it's very complex, and I'm happy with all the changes
> outside `po.pm`.
>
> * Is it worth trying to fix compatability with `indexpages`?
> * Would it make sense to go ahead and modify `page.tmpl` to use
> OTHERLANGUAGES and PERCENTTRANSLATED, instead of documenting how to modify it?
>
> --[[Joey]]

4
doc/todo/need_global_renamepage_hook.mdwn
View File

@ -107,3 +107,7 @@ hashes is desired, it could return the full set of hashes.
>>> I've implemented this nice solution in my po branch, please review. >>> I've implemented this nice solution in my po branch, please review.
>>> I'm slowly coming back to do the last bits needed to get my po and >>> I'm slowly coming back to do the last bits needed to get my po and
>>> meta branch merged. --[[intrigeri]] >>> meta branch merged. --[[intrigeri]]
>>>> It looks good. I made some small changes to it in my own po branch.
>>>> Nothing significant really. If this were not tied up in the po branch,
>>>> I've have merged it to master already. --[[Joey]]