urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Close bug (joeyh merged my patch), split out feature request, provide alternative patch

master
smcv@ 2009-07-10 18:56:47 +01:00 committed by Simon McVittie
parent 78b6a8cc76
commit 1c614914cc
2 changed files with 29 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn
View File

@ -8,22 +8,10 @@ The git commit (in my `openid` branch) says it all:
This bug affects ikiwiki.info (my commits show up in [[RecentChanges]] as http://smcv.pseudorandom.co.uk/ rather than smcv [pseudorandom.co.uk]).
> Cherry picked, thanks. --[[Joey]]
> Cherry picked, thanks. --[[Joey]]
Relatedly, the other commit on the same branch would be nice to have:
Relatedly, the other commit on the same branch would be nice to have
(edited to add: I've now moved it, and its discussion, to
[[todo/pretty-print_OpenIDs_even_if_not_enabled]]). --[[smcv]]
Allow the openid plugin to be loaded but disabled, for its side-effect of defining IkiWiki::openiduser
On various sites I have two IkiWiki instances running from the same
repository: one accessible via http and only accepting openid logins,
and one accessible via authenticated https and only accepting httpauth.
Ideally, the https version should still pretty-print OpenIDs seen in
git history.
--[[smcv]]
> I wonder if an option is the best approach. Maybe it would be better to
> simply move `openiduser` into `userlink`, and thus always support openid
> usernames whether the plugin is enabled or not. --[[Joey]]
[[!tag patch]]
[[!tag done]]

24
doc/todo/pretty-print_OpenIDs_even_if_not_enabled.mdwn 100644
View File

@ -0,0 +1,24 @@
A feature I originally requested on
[[a_related_bug|bugs/openid_no_longer_pretty-prints_OpenIDs]]:
Allow the openid plugin to be loaded but disabled, for its side-effect of defining IkiWiki::openiduser
On various sites I have two IkiWiki instances running from the same
repository: one accessible via http and only accepting openid logins,
and one accessible via authenticated https and only accepting httpauth.
Ideally, the https version should still pretty-print OpenIDs seen in
git history.
--[[smcv]]
> I wonder if an option is the best approach. Maybe it would be better to
> simply move `openiduser` into `userlink`, and thus always support openid
> usernames whether the plugin is enabled or not. --[[Joey]]
>> OK, implemented that as 'smcv/always-openid'; if you don't think that's
>> bloating the IkiWiki core too much, please consider merging. The poll on
>> [[news/openid]] indicates fairly strong support for *only* accepting OpenID
>> logins, so I think recognising OpenIDs can reasonably be considered core
>> functionality! --[[smcv]]
[[!tag patch]]