urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

po todo update: this has been fixed already.

master
intrigeri 2010-07-28 19:08:47 +02:00
parent d1a5d00156
commit 1a3e6bf3e2
1 changed files with 0 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
doc/plugins/po.mdwn
View File

@ -254,75 +254,6 @@ once [[intrigeri]]'s `meta` branch is merged.
An integration branch, called `meta-po`, merges [[intrigeri]]'s `po`
and `meta` branches, and thus has this additional features.
Language display order
----------------------
Jonas pointed out that one might want to control the order that links to
other languages are listed, for various reasons. Currently, there is no
order, as `po_slave_languages` is a hash. It would need to be converted
to an array to support this. (If twere done, twere best done quickly.)
--[[Joey]]
> Done in my po branch, preserving backward compatibility. Please
> review :) --[[intrigeri]]
>> Right, well my immediate concern is that using an array to hold
>> hash-like pairs is not very clear to the user. It will be displayed
>> in a confusing way by websetup; dumping a setup file will probably
>> also cause it to be formatted in a confusing way. And the code
>> seems to assume that the array length is even, and probably blows
>> up if it is not.. and the value is marked safe so websetup can be
>> used to modify it and break that way too. --[[Joey]]
>>> I have added a sanity check for the even array problem. This was
>>> the easy part.
>>>
>>> About the hash-like vs. dump and websetup issue,
>>> I can think of a few solutions:
>>>
>>> - keep the current hash-like pairs and unmark this setting as safe
>>> for websetup: this does not solve the dump setup issue, though;
>>> - replace the array of pairs with an array of
>>> "LANGUAGECODE|LANGUAGENAME" elements, using a pipe or whatever
>>> separator seems adequate;
>>> - add support for ordered hashes to `$config`, websetup and
>>> dumpsetup, using Tie-IxHash or any similar module;
>>> - replace the array of hash-like pairs with an array of real
>>> pairs, such as `[ ['de', 'Deutsch'], ['fr', 'Français'] ]`; this
>>> brings once again the need for `$config` to support arrays of
>>> arrays, which I have already implemented in my mirrorlist branch
>>> (see [[todo/mirrorlist_with_per-mirror_usedirs_settings]] for
>>> details).
>>>
>>> Joey, which of these solutions do you prefer? Or another one?
>>> I tend to prefer the last one. --[[intrigeri]]
>>>> I prefer the pipe separator, I think. I'm concerned that there is
>>>> no way to really sanely represent complex data structures in web
>>>> setup. --[[Joey]]
>>>>> Implemented using the pipe separator, fixed the po.t test suite
>>>>> accordingly. Please have a look. --[[intrigeri]]
>>>>>> Merged. I wonder if "ll: Lang" would be better than pipe?
>>>>>>> I've no clear opinion on this one. --[[intrigeri]]
>>>>>> Also, the compatability code for HASH is not really needed,
>>>>>> ikiwiki has not been released using a hash for it. --[[Joey]]
>>>>>>> The compatibility code is there to support the
>>>>>>> `po_slave_languages => {fr => 'Français'}` format that has
>>>>>>> been supported for ages. It's not there to support the
>>>>>>> intermediate array of hash-like pairs I proposed in the
>>>>>>> meantime.
>>>>>>>
>>>>>>> By the way, could you please have a look to the rest of my po
>>>>>>> branch? (bb22e8c4a..d98296d1db0) --[[intrigeri]]
>>>>>>>> Thought I'd already merged everything; I've got those in now.
>>>>>>>> --[[Joey]]
Pagespecs
---------