urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not pass ignored sid parameter to checksessionexpiry 

checksessionexpiry's signature changed from
(CGI::Session, CGI->param('sid')) to (CGI, CGI::Session) in commit
985b229b, but editpage still passed the sid as a useless third
parameter, and this was later cargo-culted into remove, rename and
recentchanges.
master
Simon McVittie 2014-10-11 09:28:02 +01:00
parent 4e2bfe1e17
commit 17fccbca94
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
IkiWiki/Plugin/editpage.pm
View File

@ -342,7 +342,7 @@ sub cgi_editpage ($$) {
else {
# save page
check_canedit($page, $q, $session);
checksessionexpiry($q, $session, $q->param('sid'));
checksessionexpiry($q, $session);
my $exists=-e "$config{srcdir}/$file";

2
IkiWiki/Plugin/recentchanges.pm
View File

@ -102,7 +102,7 @@ sub sessioncgi ($$) {
IkiWiki::decode_form_utf8($form);
if ($form->submitted eq 'Revert' && $form->validate) {
IkiWiki::checksessionexpiry($q, $session, $q->param('sid'));
IkiWiki::checksessionexpiry($q, $session);
my $message=sprintf(gettext("This reverts commit %s"), $rev);
if (defined $form->field('revertmessage') &&
length $form->field('revertmessage')) {

2
IkiWiki/Plugin/remove.pm
View File

@ -219,7 +219,7 @@ sub sessioncgi ($$) {
postremove($session);
}
elsif ($form->submitted eq 'Remove' && $form->validate) {
IkiWiki::checksessionexpiry($q, $session, $q->param('sid'));
IkiWiki::checksessionexpiry($q, $session);
my @pages=$form->field("page");

2
IkiWiki/Plugin/rename.pm
View File

@ -305,7 +305,7 @@ sub sessioncgi ($$) {
postrename($q, $session, $src);
}
elsif ($form->submitted eq 'Rename' && $form->validate) {
IkiWiki::checksessionexpiry($q, $session, $q->param('sid'));
IkiWiki::checksessionexpiry($q, $session);
# These untaints are safe because of the checks
# performed in check_canrename later.