urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

comments (finally)

master
Joey Hess 2010-11-22 14:05:37 -04:00
parent a6c3d71787
commit 178d6a16c2
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
View File

@ -181,6 +181,16 @@ New API added by this branch:
* `urlto(x, y, 'local')` uses `$local_url` instead of `$config{url}` * `urlto(x, y, 'local')` uses `$local_url` instead of `$config{url}`
> Yikes. I see why you wanted to keep it to 3 parameters (4 is too many,
> and po overrides it), but I dislike overloading the third parameter
> like that.
>
> There are fairly few calls to `urlto($foo, $bar)`, so why not
> make that always return the semi-local url form, and leave the third
> parameter for the cases that need a true fully-qualified url.
> The new form for local urls will typically be only a little bit longer,
> except in the unusual case where the cgiurl is elsewhere. --[[Joey]]
* `IkiWiki::baseurl` has a new second argument which works like the * `IkiWiki::baseurl` has a new second argument which works like the
third argument of `urlto` third argument of `urlto`
@ -199,9 +209,13 @@ Bugs:
`cgiurl(cgiurl => $config{cgiurl}, ...)`, `cgiurl(cgiurl => $config{cgiurl}, ...)`,
although that does look a bit strange although that does look a bit strange
> I agree that makes sense. --[[Joey]]
* It occurs to me that `IkiWiki::cgiurl` could probably benefit from being * It occurs to me that `IkiWiki::cgiurl` could probably benefit from being
exported? Perhaps also `IkiWiki::baseurl`? exported? Perhaps also `IkiWiki::baseurl`?
> Possibly, see [[firm_up_plugin_interface]]. --[[Joey]]
* Or, to reduce use of the unexported `baseurl` function, it might make * Or, to reduce use of the unexported `baseurl` function, it might make
sense to give `urlto` a special case that references the root of the wiki, sense to give `urlto` a special case that references the root of the wiki,
with a trailing slash ready to append stuff: perhaps `urlto('/')`, with a trailing slash ready to append stuff: perhaps `urlto('/')`,
@ -210,3 +224,6 @@ Bugs:
do_something(baseurl => urlto('/', undef, local)`); do_something(baseurl => urlto('/', undef, local)`);
do_something_else(urlto('/').'style.css'); do_something_else(urlto('/').'style.css');
IkiWiki::redirect(urlto('/', undef, 1)); IkiWiki::redirect(urlto('/', undef, 1));
> AFACIS, `baseurl` is only called in 3 places so I don't think that's
> needed. --[[Joey]]