* perl is broken: print "" || die fails! Work around this insanity.

master
joey 2007-02-20 22:19:28 +00:00
parent 1334cc55ba
commit 135e5fc63a
3 changed files with 8 additions and 2 deletions

View File

@ -292,7 +292,9 @@ sub writefile ($$$;$$) { #{{{
$writer->(\*OUT, $cleanup);
}
else {
print OUT $content || error("failed writing to $newfile: $!", $cleanup);
if (length $content) {
print OUT $content || error("failed writing to $newfile: $!", $cleanup);
}
}
close OUT || error("failed saving $newfile: $!", $cleanup);
rename($newfile, "$destdir/$file") ||

3
debian/changelog vendored
View File

@ -23,8 +23,9 @@ ikiwiki (1.44) UNRELEASED; urgency=low
* Make img plugin not fail immediately if Image::Magick is not available.
This lets ikiwiki not build depend on perlmagic.
* Detect old versions of xgettext and avoid using them.
* perl is broken: print "" || die fails! Work around this insanity.
-- Joey Hess <joeyh@debian.org> Tue, 20 Feb 2007 04:43:31 -0500
-- Joey Hess <joeyh@debian.org> Tue, 20 Feb 2007 17:13:37 -0500
ikiwiki (1.43) unstable; urgency=low

View File

@ -410,6 +410,9 @@ Index: linkmap.pm
> This is probably supposed to be `$mapitems{$item}=urlto($item, $params{destpage});`,
> which does indeed remove one more `htmlpage` call from the plugins. I can't actually
> try it: "failed writing to dst/ts.png.ikiwiki-new: Inappropriate ioctl for device".
>> Crazy perl bug that ioctl thing. Worked around now in svn. --[[Joey]]
> After this probable fix, in fact, all uses of htmlpage in the plugins are used to
> construct an absolute address: the absolute url in most cases, so an `absurl`
> call could be added to be used instead of htmlpage, and something else in the