From 118e6f718be1932dfbe553d8a844a6407659cba3 Mon Sep 17 00:00:00 2001 From: "http://smcv.pseudorandom.co.uk/" Date: Sat, 4 Jun 2011 15:40:24 +0000 Subject: [PATCH] found it --- ...s_are_not_sorted_by_their_date_attribute.mdwn | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/doc/bugs/Comments_are_not_sorted_by_their_date_attribute.mdwn b/doc/bugs/Comments_are_not_sorted_by_their_date_attribute.mdwn index a656a33a0..39c744f9f 100644 --- a/doc/bugs/Comments_are_not_sorted_by_their_date_attribute.mdwn +++ b/doc/bugs/Comments_are_not_sorted_by_their_date_attribute.mdwn @@ -46,3 +46,19 @@ The presentation of the resulting comments is not sorted by this date, which I w >>> Sorting by filename would only be useful with >>> [[!cpan Sort::Naturally]], since normal `cmp` ordering would break pages >>> with more than 9 comments. --s + +>>> OK, I've found the bug. As internal pages, comments are not preprocessed +>>> (and so their date attributes do not have a chance to take effect) until +>>> they are already being inlined, by which time they have already been +>>> sorted by the files' ctimes. Possible fixes include: +>>> +>>> * scan any modified/created internal pages (including preprocessing them +>>> in scan mode) before rendering any page, fixing all possible bugs of this +>>> form but causing a slower scan phase +>>> +>>> * list and scan the comments below a given page in its `pagetemplate` +>>> hook before inlining them, causing a slower build phase for pages with +>>> many comments +>>> +>>> I think the former is a more general fix, and I'll try to implement +>>> it. --[[smcv]]