Notes from an evening's debugging.

master
Amitai Schlair 2012-02-05 01:24:09 -05:00
parent 6753235d98
commit 0a05ac9205
1 changed files with 11 additions and 0 deletions

11
t/cvs.t
View File

@ -26,6 +26,7 @@ sub test_web_comments {
# - when the first comment for page.mdwn is added, and page/ is # - when the first comment for page.mdwn is added, and page/ is
# created to hold the comment, page/ isn't added to CVS control, # created to hold the comment, page/ isn't added to CVS control,
# so the comment isn't either # so the comment isn't either
# - can't reproduce after chmod g+s ikiwiki.cgi (20120204)
# - side effect for moderated comments: after approval they # - side effect for moderated comments: after approval they
# show up normally AND are still pending, too # show up normally AND are still pending, too
# - comments.pm treats rcs_commit_staged() as returning conflicts? # - comments.pm treats rcs_commit_staged() as returning conflicts?
@ -35,6 +36,9 @@ sub test_chdir_magic {
# cvs.pm operations are always occurring inside $config{srcdir} # cvs.pm operations are always occurring inside $config{srcdir}
# other ikiwiki operations are occurring wherever, and are unaffected # other ikiwiki operations are occurring wherever, and are unaffected
# when are we bothering with "local $CWD" and when aren't we? # when are we bothering with "local $CWD" and when aren't we?
# after commit, presumably only with post-commit hook enabled:
#> Use of chdir('') or chdir(undef) as chdir() is deprecated at
#> /usr/pkg/lib/perl5/vendor_perl/5.14.0/File/chdir.pm line 45.
} }
sub test_cvs_info { sub test_cvs_info {
@ -132,6 +136,11 @@ sub test_rcs_prepedit {
# for existing file, returns latest revision in repo # for existing file, returns latest revision in repo
# - what's this used for? should it return latest revision in checkout? # - what's this used for? should it return latest revision in checkout?
# for new file, returns empty string # for new file, returns empty string
# netbsd web log says "could not open lock file"
# XXX does this work right?
# how about with un-added dirs in the srcdir?
# how about with cvsps.core lying around?
} }
sub test_rcs_commit { sub test_rcs_commit {
@ -146,6 +155,8 @@ sub test_rcs_commit {
# git.pm receives "session" param -- useful here? # git.pm receives "session" param -- useful here?
# web commits start with "web commit {by,from} " # web commits start with "web commit {by,from} "
# seeing File::chdir errors on commit? # seeing File::chdir errors on commit?
# XXX commit can fail due to "could not open lock file"
} }
sub test_rcs_commit_staged { sub test_rcs_commit_staged {