Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
commit
0740855836
|
@ -0,0 +1,25 @@
|
|||
The [[plugins/img]] plugin is not generating the proper `class`
|
||||
attribute in its HTML output.
|
||||
|
||||
The plugin receives something like the following:
|
||||
|
||||
\[[!img 129199047595759991.jpg class="centered"]]
|
||||
|
||||
And is supossed to generate an HTML code like the following:
|
||||
|
||||
<img src="129199047595759991.jpg" class="centered" />
|
||||
|
||||
But is generating the following
|
||||
|
||||
<img src="129199047595759991.jpg" class="centered img" />
|
||||
|
||||
This seems to be happening with all images inserted using the plugin (that use
|
||||
the `class=yaddayadda` argument to the `img` directive.) I remember it didn't
|
||||
happen before, and I suspect an ikiwiki upgrade is to blame. I tested with a
|
||||
blog created from scratch, and a single post, and the problem appeared there
|
||||
too.
|
||||
|
||||
This is happening with version 3.20100815 of ikiwiki.
|
||||
|
||||
[[jerojasro]]
|
||||
|
|
@ -0,0 +1,8 @@
|
|||
[[!comment format=mdwn
|
||||
username="https://www.google.com/accounts/o8/id?id=AItOawmlZJCPogIE74m6GSCmkbJoMZiWNOlXcjI"
|
||||
nickname="Ian"
|
||||
subject="comment 1"
|
||||
date="2010-09-24T19:01:08Z"
|
||||
content="""
|
||||
+1 for a \"revert\" web plugin which at least handles the simple cases. -- Ian Osgood, The TOVA Company
|
||||
"""]]
|
|
@ -0,0 +1 @@
|
|||
The problem I have in my tables, is that some fields contain example HTML that needs to be escaped.
|
|
@ -10,4 +10,4 @@ log back in, try out the OpenID signup process if you don't already have an
|
|||
OpenID, and see how OpenID works for you. And let me know your feelings about
|
||||
making such a switch. --[[Joey]]
|
||||
|
||||
[[!poll 65 "Accept only OpenID for logins" 21 "Accept only password logins" 36 "Accept both"]]
|
||||
[[!poll 66 "Accept only OpenID for logins" 21 "Accept only password logins" 36 "Accept both"]]
|
||||
|
|
|
@ -27,8 +27,8 @@ suggested for addition (possibly by means of a plugin):
|
|||
> > <!-- there are so many people who misspell this, let's create a redirect -->
|
||||
> > \[[!alias Grece list=false]]
|
||||
>
|
||||
> This page by itself will redirect from the "Hellas" and "Hellenic Republic"
|
||||
> pages as if they both contained just:
|
||||
> This page by itself will redirect from the "Hellas", "Hellenic Republic" and
|
||||
> "Grece" pages as if they both contained just:
|
||||
>
|
||||
> > \[[!meta redir="Greece"]]
|
||||
>
|
||||
|
@ -44,4 +44,29 @@ The proposed plugin/directive could be extended, eg. by also including
|
|||
old-style redirects in the alias list, but that might introduce unwanted
|
||||
coupling with the meta directive.
|
||||
|
||||
-----------------
|
||||
|
||||
On second thought, implementing this might have similarities with
|
||||
[[todo/auto-create tag pages according to a template]] -- the auto-created
|
||||
pages would, if the way of the alias directive is followed, not create physical
|
||||
files, though, but be created just when someone edits them.
|
||||
|
||||
If multiple plugins do such a trick, they would have to fight over who comes
|
||||
first. If, for example, we have a setup where not yet created tag pages are
|
||||
automatically generated as "\[[!inline pages="link(<TMPL_VAR TAG>)"
|
||||
archive="yes"]]" and aliases are enabled, and a non-tag pages grabs a tag as an
|
||||
alias (as to redirect all taglinks of the tag to itself), there are two
|
||||
possibilities:
|
||||
|
||||
* The autotag plugin comes first:
|
||||
* autotag sees the missing tag and creates its "\[[!inline" stuff
|
||||
* alias sees that there is already content and adds its prefix
|
||||
* The alias plugin comes first (this is the prefered way):
|
||||
* alias sees the empty page, sees it is not contested by other alias
|
||||
directives and creates its "\[[!meta" redirect
|
||||
* autotag sees there is already content and doesn't do anything
|
||||
|
||||
That issue could be handled with "priority number" on the hook, with plugins
|
||||
with a lower number being called first.
|
||||
|
||||
[[!tag wishlist]]
|
||||
|
|
|
@ -248,4 +248,17 @@ I've tested it fairly thouroughly. --[[Joey]]
|
|||
[a358d74bef51dae31332ff27e897fe04834571e6]: http://git.liegesta.at/?p=ikiwiki.git;a=commitdiff;h=a358d74bef51dae31332ff27e897fe04834571e6 (commitdiff for a358d74bef51dae31332ff27e897fe04834571e6)
|
||||
[981400177d68a279f485727be3f013e68f0bf691]: http://git.liegesta.at/?p=ikiwiki.git;a=commitdiff;h=981400177d68a279f485727be3f013e68f0bf691 (commitdiff for 981400177d68a279f485727be3f013e68f0bf691)
|
||||
|
||||
-------------------
|
||||
|
||||
Even if this is already marked as done, I'd like to suggest an alternative
|
||||
solution:
|
||||
|
||||
Instead of creating a file that gets checked in into the RCS, the source files
|
||||
could be left out and the output files be written as long as there is no
|
||||
physical source file (think of a virtual underlay). Something similar would be
|
||||
required to implement [[todo/alias directive]], which couldn't be easily done
|
||||
by writing to the RCS as the page's contents can change depending on which
|
||||
other pages claim it as an alias. --[[chrysn]]
|
||||
|
||||
|
||||
[[!tag done]]
|
||||
|
|
Loading…
Reference in New Issue