urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git: don't redundantly pass "--" to git_sha1 

git_sha1 already puts "--" before its arguments, so

    git_sha1_file($dir, 'doc/index.mdwn')

would have incorrectly invoked

    git rev-list --max-count=1 HEAD -- -- doc/index.mdwn

If there is no file in the wiki named "--", that's harmless, because
it merely names the latest revision in which either "--" or
"doc/index.mdwn" changed. However, it could return incorrect results
if there is somehow a file named "--".
master
Simon McVittie 2017-01-09 13:58:58 +00:00
parent 59632384d9
commit 0463357392
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
IkiWiki/Plugin/git.pm
View File

@ -578,7 +578,7 @@ sub rcs_find_changes ($) {
sub git_sha1_file ($$) { sub git_sha1_file ($$) {
my $dir=shift; my $dir=shift;
my $file=shift; my $file=shift;
return git_sha1($dir, "--", $file); return git_sha1($dir, $file);
} }
sub git_sha1 ($@) { sub git_sha1 ($@) {