urosm
/
ikiwiki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ikiwiki-mass-rebuild: Don't trust $! when setting $) 

A better fix, just check that what $) returns is what it was asked to set,
and ignore $! entirely.
master
Joey Hess 2008-05-31 14:46:16 -04:00
parent cc26a49925
commit 0353882a66
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
debian/changelog vendored
View File

@ -1,7 +1,7 @@
ikiwiki (2.49) UNRELEASED; urgency=low ikiwiki (2.49) UNRELEASED; urgency=low
* haiku: Generate valid xhtml. * haiku: Generate valid xhtml.
* ikiwiki-mass-rebuild: under $! before setting $) to avoid strange errno issue * ikiwiki-mass-rebuild: Don't trust $! when setting $)
-- Joey Hess <joeyh@debian.org> Fri, 30 May 2008 19:08:54 -0400 -- Joey Hess <joeyh@debian.org> Fri, 30 May 2008 19:08:54 -0400

4
ikiwiki-mass-rebuild
View File

@ -34,9 +34,7 @@ sub processline {
if (! $pid) { if (! $pid) {
my ($uuid, $ugid) = (getpwnam($user))[2, 3]; my ($uuid, $ugid) = (getpwnam($user))[2, 3];
my $grouplist=join(" ", $ugid, $ugid, supplemental_groups($user)); my $grouplist=join(" ", $ugid, $ugid, supplemental_groups($user));
undef $!; if (($)=$grouplist) ne $grouplist) {
$)=$grouplist;
if ($!) {
die "failed to set egid $grouplist: $!"; die "failed to set egid $grouplist: $!";
} }
$(=$ugid; $(=$ugid;