2006-08-02 07:32:10 +02:00
|
|
|
ikiwiki currently stores some key data in .ikiwiki/index. Some plugins need a
|
|
|
|
way to store additional data, and ideally it would be something managed by
|
|
|
|
ikiwiki instead of ad-hoc because:
|
|
|
|
|
|
|
|
* consistency is good
|
|
|
|
* ikiwiki knows when a page is removed and can stop storing data for that
|
|
|
|
page; plugins have to go to some lengths to track that and remove their
|
|
|
|
data
|
|
|
|
* it's generally too much code and work to maintain a separate data store
|
|
|
|
|
|
|
|
The aggregate plugin is a use-case: of 324 lines, 70 are data storage and
|
|
|
|
another 10 handle deletion. Also, it's able to use a format very like
|
|
|
|
ikiwiki's, but it does need to store some lists in there, which complicates
|
|
|
|
it some and means that a very naive translation between a big per-page hash
|
|
|
|
and the .index won't be good enough.
|
|
|
|
|
|
|
|
The current ikiwiki index format is not very flexible, although it is at
|
|
|
|
least fairly easy and inexpensive to parse as well as hand-edit.
|
|
|
|
|
|
|
|
Would this do: ?
|
|
|
|
|
|
|
|
* Plugins can register savestate and loadstate hooks. The hook id is the
|
|
|
|
key used in the index file that the hook handles.
|
|
|
|
* loadstate hooks are called and passed a list of all values for a page
|
|
|
|
that for the registered key, and the page name, and should store the data
|
|
|
|
somewhere
|
|
|
|
* savestate hooks are called and passed a page, and should return a list of
|
|
|
|
all values for that key for that page
|
|
|
|
* If they need anything more complex than a list of values, they will need
|
|
|
|
to encode it somehow in the list.
|
|
|
|
|
|
|
|
Hmm, that's potentially a lot of function calls per page eave load/save
|
|
|
|
though.. For less function calls, only call each hook *once* per load/save,
|
|
|
|
and it is passed/returns a big hash of pages and the values for each page.
|
|
|
|
(Which probably means `%state=@_` for load and `return %state` for save.)
|
|
|
|
|
|
|
|
It may also be better to just punt on lists, and require plugins that need
|
|
|
|
even lists to encode them. Especially since in many cases, `join(" ", @list)`
|
2006-08-02 07:35:51 +02:00
|
|
|
will do. Er hmm, if I do that though, I'm actually back to a big global
|
|
|
|
%page_data that plugins can just toss data into, arn't I? So maybe that's
|
2006-08-02 07:37:13 +02:00
|
|
|
%the right approach after all, hmm.. Except that needing to decode/encode list
|
|
|
|
data all the time when using it would quite suck, so no, let's not do that.
|
2006-08-02 07:32:10 +02:00
|
|
|
|
|
|
|
Note that for the aggregate plugin to use this, it will need some changes:
|
|
|
|
|
|
|
|
* guid data will need to be stored as part of the data for the page
|
2006-11-01 07:05:08 +01:00
|
|
|
that was aggregated from that guid. Except, expired pages don't exit, but
|
2007-05-09 22:01:55 +02:00
|
|
|
still have guid data to store. Hmm. I suppose the guid data could be
|
|
|
|
considered to be associated with the page that contains the aggregate
|
|
|
|
directive then.
|
2006-08-02 07:32:10 +02:00
|
|
|
* All feeds will need to be marked as removable in loadstate, and only
|
|
|
|
unmarked if seen in preprocess. Then savestate will need to not only
|
|
|
|
remove any feeds still marked as such, but do the unlinking of pages
|
|
|
|
aggregated from them too.
|
|
|
|
|
|
|
|
If I do this, I might as well also:
|
|
|
|
|
|
|
|
* Change the link= link= stuff to just links=link+link etc.
|
|
|
|
* Change the delimiter from space to comma; commas are rare in index files,
|
|
|
|
so less ugly escaped delimiters to deal with.
|
2007-10-23 02:02:53 +02:00
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
The [[plugins/calendar]] plugin could use plugin data storage to record
|
|
|
|
which pages have a calendar for the current time. Then ensure they are
|
|
|
|
rebuilt at least once a day. Currently, it needs a cron job to rebuild
|
|
|
|
the *whole* wiki every day; with this enhancement, the cron job would only
|
|
|
|
rebuild the few pages that really need it.
|
2007-12-08 23:40:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
New design:
|
|
|
|
|
|
|
|
`%Ikiwiki::state` is an exported hash that stores per-page state.
|
|
|
|
Set with `$state{$page}{id}{key}=$value`. The `id` is the same `id` passed
|
|
|
|
to `hook()`.
|
|
|
|
|
|
|
|
This is stored in the index like:
|
|
|
|
|
|
|
|
src=foo.mdwn dest=bar.mdwn id_key=value [...]
|
|
|
|
|
|
|
|
The underscore ensures that there's no conflict with ikiwiki's own
|
|
|
|
state variables. (Note that `id` and `key` need to be encoded here.)
|
|
|
|
|
|
|
|
Plugins are reponsible for deleting old state info, though ikiwiki will
|
|
|
|
handle deleting it if a page is removed.
|
|
|
|
|
|
|
|
Ikiwiki needs to know when it can drop state for plugins that are no longer
|
|
|
|
enabled. This is done via `hook()` -- if a plugin registers a hook
|
|
|
|
ikiwiki knows it's still active, and preserves the state for the hook id.
|
|
|
|
If not, that state will be dropped.
|
|
|
|
|
|
|
|
[[done]]!! Now to use it..
|