From 9430598b01fc9c5aac6056fbd4ea4a304c858094 Mon Sep 17 00:00:00 2001
From: "max.mehl" <max.mehl@fsfe.org>
Date: Wed, 30 Aug 2017 15:51:47 +0200
Subject: [PATCH 1/4] rename image files

---
 site/static/img/signees/{edri-logo.png => edri.png} | Bin
 .../static/img/signees/{lugos_big.png => lugos.png} | Bin
 .../img/signees/{Logo_okfde_black.png => okf.png}   | Bin
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename site/static/img/signees/{edri-logo.png => edri.png} (100%)
 rename site/static/img/signees/{lugos_big.png => lugos.png} (100%)
 rename site/static/img/signees/{Logo_okfde_black.png => okf.png} (100%)

diff --git a/site/static/img/signees/edri-logo.png b/site/static/img/signees/edri.png
similarity index 100%
rename from site/static/img/signees/edri-logo.png
rename to site/static/img/signees/edri.png
diff --git a/site/static/img/signees/lugos_big.png b/site/static/img/signees/lugos.png
similarity index 100%
rename from site/static/img/signees/lugos_big.png
rename to site/static/img/signees/lugos.png
diff --git a/site/static/img/signees/Logo_okfde_black.png b/site/static/img/signees/okf.png
similarity index 100%
rename from site/static/img/signees/Logo_okfde_black.png
rename to site/static/img/signees/okf.png

From 105921477284edf99bb55b7002ae7d204e5b3342 Mon Sep 17 00:00:00 2001
From: "max.mehl" <max.mehl@fsfe.org>
Date: Wed, 30 Aug 2017 16:29:06 +0200
Subject: [PATCH 2/4] add optional comment field to sign form

---
 site/config.toml                  | 3 ++-
 site/layouts/partials/action.html | 3 +++
 site/static/css/custom.css        | 8 ++++++++
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/site/config.toml b/site/config.toml
index 10c6a2a..e67e9a8 100644
--- a/site/config.toml
+++ b/site/config.toml
@@ -79,8 +79,9 @@ DefaultContentLanguage = "en"
   description = "More than XY organisations support this call for action by signing our [Open Letter](/openletter). Help us to make an impact by signing it, too! We will hand over all signatures to representatives all over Europe that are debating software freedom in public administration."
   formName = "Name (required)"
   formEmail = "Email (required)"
-  formCountry = "Country"
+  formCountry = "Your Country"
   formZip = "ZIP Code"
+  formComment = "Your comment (max. 140 characters)"
   formPermissionPriv = "I have read and accepted the [privacy statement](/privacy)"
   formPermissionNews = "I want to stay informed about the future of this campaign"
   formPermissionPub = "I want my signature to appear in the [list of signatures](/openletter#signatures)"
diff --git a/site/layouts/partials/action.html b/site/layouts/partials/action.html
index 40a6ded..887e91e 100644
--- a/site/layouts/partials/action.html
+++ b/site/layouts/partials/action.html
@@ -52,6 +52,9 @@
                   <label class="sign-input form-zp">
                     <input name="zip" placeholder="{{ .Site.Params.action.formZip }}" type="text" />
                   </label>
+                  <label class="sign-input form-co">
+                    <input name="comment" placeholder="{{ .Site.Params.action.formComment }}" type="text" maxlength="140" />
+                  </label>
                   <p class="form-pe">
                     <label class="form-pe">
                       <input name="permissionPriv" value="yes" type="checkbox" required /> {{ .Site.Params.action.formPermissionPriv | markdownify }}
diff --git a/site/static/css/custom.css b/site/static/css/custom.css
index a181705..f521b48 100644
--- a/site/static/css/custom.css
+++ b/site/static/css/custom.css
@@ -101,6 +101,7 @@
 }
 #action form label {
   font-weight: 400;
+  margin: 5px 3px;
 }
 .sign-input {
   position: relative;
@@ -119,6 +120,9 @@
   width: 270px;
   height: 31px;
 }
+.sign-input.form-co input {
+  width: 554px;
+}
 .sign-input select {
   background: rgba(255, 255, 255, 0.5) none repeat scroll 0 0;
   border-radius: 7px;
@@ -140,6 +144,10 @@
   content: "\f08d";
   padding-left: 3px;
 }
+.form-co:before {
+  content: "\f27a";
+  padding-left: 3px;
+}
 p.form-pe {
   text-align: left;
   max-width: 530px; /* to not let the checkboxed go far more left than the input boxes above */

From e39ad618be353b1859d0f7db18081f18e208ad76 Mon Sep 17 00:00:00 2001
From: "max.mehl" <max.mehl@fsfe.org>
Date: Wed, 30 Aug 2017 16:32:07 +0200
Subject: [PATCH 3/4] add comment field variable in sign.php

---
 site/static/cgi/sign.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/site/static/cgi/sign.php b/site/static/cgi/sign.php
index 9c062da..b9b1500 100644
--- a/site/static/cgi/sign.php
+++ b/site/static/cgi/sign.php
@@ -88,6 +88,7 @@ if(empty($action)) {
   $email = isset($_POST['email']) ? $_POST['email'] : false;
   $country = isset($_POST['country']) ? $_POST['country'] : false;
   $zip = isset($_POST['zip']) ? $_POST['zip'] : false;
+  $comment = isset($_POST['comment']) ? $_POST['comment'] : false;
   $permPriv = isset($_POST['permissionPriv']) ? $_POST['permissionPriv'] : false;
   $permNews = isset($_POST['permissionNews']) ? $_POST['permissionNews'] : false;
   $permPub = isset($_POST['permissionPub']) ? $_POST['permissionPub'] : false;
@@ -141,6 +142,7 @@ if ($action === "sign") {
                   "email" => $email,
                   "country" => $country,
                   "zip" => $zip,
+                  "comment" => $comment,
                   "permPriv" => $permPriv,
                   "permNews" => $permNews,
                   "permPub" => $permPub,

From 8c8db8a908e3f4c51f909f507fc586c8a55f5433 Mon Sep 17 00:00:00 2001
From: "max.mehl" <max.mehl@fsfe.org>
Date: Wed, 30 Aug 2017 17:24:34 +0200
Subject: [PATCH 4/4] change signature table display, show comment, and make it
 scrollable

---
 site/content/openletter.en.md               |  2 +-
 site/layouts/partials/subpage_sigtable.html |  8 ++--
 site/static/css/custom.css                  | 42 +++++++++++++++++++--
 3 files changed, 44 insertions(+), 8 deletions(-)

diff --git a/site/content/openletter.en.md b/site/content/openletter.en.md
index 1a216ce..bb3188a 100644
--- a/site/content/openletter.en.md
+++ b/site/content/openletter.en.md
@@ -3,9 +3,9 @@ title: Open Letter
 type: page
 layout: subpage
 sigtable: true
-tableZip: Zip Code
 tableName: Name
 tableCountry: Country
+tableComment: Comment
 ---
 
 Publicly funded software has to be [Free Software][fs]. While there are plenty of good reasons for that, many politicians don't know about the importance of software yet.
diff --git a/site/layouts/partials/subpage_sigtable.html b/site/layouts/partials/subpage_sigtable.html
index 24c0e5f..d81caa2 100644
--- a/site/layouts/partials/subpage_sigtable.html
+++ b/site/layouts/partials/subpage_sigtable.html
@@ -1,17 +1,19 @@
 <table id="signatures">
-  <tbody>
+  <thead>
     <tr>
       <th>{{ .Params.tableName }}</th>
       <th>{{ .Params.tableCountry }}</th>
-      <th>{{ .Params.tableZip }}</th>
+      <th>{{ .Params.tableComment }}</th>
     </tr>
+  </thead>
+  <tbody>
     {{ range .Site.Data.signatures.data }}
       {{ range sort . "id" "desc" }}
         {{ if (eq .confirmed "yes") | and (eq .permPub "yes")  }}
          <tr>
             <td>{{ .name }}</td>
             <td>{{ .country }}</td>
-            <td>{{ .zip }}</td>
+            <td>{{ .comment }}</td>
          </tr>
         {{ end }}
       {{ end }}
diff --git a/site/static/css/custom.css b/site/static/css/custom.css
index f521b48..5ab52ec 100644
--- a/site/static/css/custom.css
+++ b/site/static/css/custom.css
@@ -162,14 +162,48 @@ p.form-pe a {
 
 /* SIGNATURE TABLE */
 table#signatures {
-  margin: 0 auto;
+  display: table;
+  width: 100%;
+}
+table#signatures thead, table#signatures tbody {
+  width: 100%;
+}
+table#signatures td:nth-child(1), table#signatures th:nth-child(1) {
+  width: 25%;
+}
+table#signatures td:nth-child(2), table#signatures th:nth-child(2) {
+  width: 25%;
+}
+table#signatures td:nth-child(3), table#signatures th:nth-child(3) {
+  width: 50%;
+}
+table#signatures thead {
+  overflow-y: scroll;
+  display: table;
+  width: calc(100% - 16px);
+  background-color: rgba(230, 230, 230, 0.2);
+}
+table#signatures tbody {
+  overflow: auto;
+  height: 250px;
+  display: block;
+}
+table#signatures tr {
+  width: 100%;
+  display: table;
+  text-align: left;
 }
 table#signatures th, table#signatures td {
-  border: 1px solid darkgrey;
-  border-collapse: collapse;
+  border-bottom: 1px solid darkgrey;
   text-align: left;
-  padding: 2px;
+  padding: 5px;
 }
+table#signatures tr:nth-child(even) {
+  background-color: rgba(230, 230, 230, 0.05);
+} 
+table#signatures tr:hover {
+  background-color: rgba(230, 230, 230, 0.1);
+} 
 
 /* SPECIAL LINK UNDERLINE EFFECT */
 a:not(.btn):not(.hiddenlink) {