From 7f4683e0fe9b2b89dcf8fe2bfba420376640196c Mon Sep 17 00:00:00 2001 From: Meng Li <34143965+Meng6@users.noreply.github.com> Date: Thu, 14 Oct 2021 09:26:06 -0400 Subject: [PATCH] Feature/screen default maxlength (#164) Updated the default IGNORE_EPISODES_LONGER_THAN to be 6 hours for screen RAPIDS provider --- config.yaml | 2 +- docs/change-log.md | 1 + docs/features/phone-screen.md | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config.yaml b/config.yaml index 18796fe5..9f0f4ed5 100644 --- a/config.yaml +++ b/config.yaml @@ -293,7 +293,7 @@ PHONE_SCREEN: COMPUTE: False REFERENCE_HOUR_FIRST_USE: 0 IGNORE_EPISODES_SHORTER_THAN: 0 # in minutes, set to 0 to disable - IGNORE_EPISODES_LONGER_THAN: 0 # in minutes, set to 0 to disable + IGNORE_EPISODES_LONGER_THAN: 360 # in minutes, set to 0 to disable FEATURES: ["countepisode", "sumduration", "maxduration", "minduration", "avgduration", "stdduration", "firstuseafter"] # "episodepersensedminutes" needs to be added later EPISODE_TYPES: ["unlock"] SRC_SCRIPT: src/features/phone_screen/rapids/main.py diff --git a/docs/change-log.md b/docs/change-log.md index 430521e7..d40d2d07 100644 --- a/docs/change-log.md +++ b/docs/change-log.md @@ -3,6 +3,7 @@ - Refactor PHONE_CALLS RAPIDS provider to compute features based on call episodes or events - Refactor PHONE_LOCATIONS DORYAB provider to compute features based on location episodes - Temporary revert PHONE_LOCATIONS BARNETT provider to use R script +- Update the default IGNORE_EPISODES_LONGER_THAN to be 6 hours for screen RAPIDS provider ## v1.5.0 - Update Barnett location features with faster Python implementation - Fix rounding bug in data yield features diff --git a/docs/features/phone-screen.md b/docs/features/phone-screen.md index b4a8effb..64ae80d8 100644 --- a/docs/features/phone-screen.md +++ b/docs/features/phone-screen.md @@ -32,7 +32,7 @@ Parameters description for `[PHONE_SCREEN][PROVIDERS][RAPIDS]`: |`[FEATURES]` | Features to be computed, see table below |`[REFERENCE_HOUR_FIRST_USE]` | The reference point from which `firstuseafter` is to be computed, default is midnight |`[IGNORE_EPISODES_SHORTER_THAN]` | Ignore episodes that are shorter than this threshold (minutes). Set to 0 to disable this filter. -|`[IGNORE_EPISODES_LONGER_THAN]` | Ignore episodes that are longer than this threshold (minutes). Set to 0 to disable this filter. +|`[IGNORE_EPISODES_LONGER_THAN]` | Ignore episodes that are longer than this threshold (minutes), default is 6 hours. Set to 0 to disable this filter. |`[EPISODE_TYPES]` | Currently we only support `unlock` episodes (from when the phone is unlocked until the screen is off)