From aa8d1c5e07f619b6b1bd6439e182b81bbee5a158 Mon Sep 17 00:00:00 2001 From: 3geek14 Date: Thu, 3 Aug 2023 04:02:40 -0400 Subject: [PATCH] Clarify custom keycode enum requirement for PRs (#21648) --- docs/pr_checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index d22e912e86..0d6b4db206 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -42,7 +42,7 @@ If there are any inconsistencies with these recommendations, you're best off [cr - `#include QMK_KEYBOARD_H` preferred to including specific board files - prefer layer `enum`s to `#define`s -- require custom keycode `enum`s to `#define`s, first entry must have ` = SAFE_RANGE` +- custom keycode `enum`s must have first entry `= SAFE_RANGE` - terminating backslash (`\`) in lines of LAYOUT macro parameters is superfluous and should be removed - some care with spacing (e.g., alignment on commas or first char of keycodes) makes for a much nicer-looking keymap